Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External sources not updated in SDC iterations + Effect on Div u #429

Open
baperry2 opened this issue Oct 21, 2024 · 0 comments
Open

External sources not updated in SDC iterations + Effect on Div u #429

baperry2 opened this issue Oct 21, 2024 · 0 comments

Comments

@baperry2
Copy link
Collaborator

Coupling with external sources (soot, spray, radiation, etc) could be made tighter by recomputing the external forcing at step/iteration (n+1,k) during the SDC iteration process, and using S_{n+1/2} = 0.5(S_n + S_{n+1}) as the effective forcing. #427 moves in this direction but doe not fully implement that yet.

If the present implementation is left alone, Div u should be recomputed at the beginning of each timestep, such that it is using the external forcing for the new timestep rather than the old timestep. A consequence of not recomputing Div u is that spray sources are not included at all for the first timestep when computing Div u in the current implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant