address rotation source in spherical 2d coordinate #2967
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This addresses #2927 regarding the rotation bit.$\Omega \hat{z} = \Omega[\cos(\theta) \hat{r} - \sin(\theta) \hat{\theta})]$ .
I mainly separated
get_omega()
to return magnitude of the angular frequency,then made
get_omega_vec()
to depend on j, sinceTo deal with the problem of position vector, I just made sure
r
is (r,0,0) before the cross_product call.I also made computing dt_omega_matrix into a separate function since omega vector now varies.
PR motivation
PR checklist
CHANGES
file has been updated, if appropriate