Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address rotation source in spherical 2d coordinate #2967

Draft
wants to merge 13 commits into
base: development
Choose a base branch
from

Conversation

zhichen3
Copy link
Collaborator

PR summary

This addresses #2927 regarding the rotation bit.
I mainly separated get_omega() to return magnitude of the angular frequency,
then made get_omega_vec() to depend on j, since $\Omega \hat{z} = \Omega[\cos(\theta) \hat{r} - \sin(\theta) \hat{\theta})]$.
To deal with the problem of position vector, I just made sure r is (r,0,0) before the cross_product call.
I also made computing dt_omega_matrix into a separate function since omega vector now varies.

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale zingale mentioned this pull request Sep 26, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants