Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up the artifical viscosity routines #2934

Merged
merged 5 commits into from
Jul 28, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Jul 28, 2024

we just need to compute divu on the face once
this is prep for limiting the artifical viscosity coefficient for species conservation

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

we just need to compute divu on the face once
this is prep for limiting the artifical viscosity coefficient
for species conservation
@zingale
Copy link
Member Author

zingale commented Jul 28, 2024

this is prep for #2228

@zingale
Copy link
Member Author

zingale commented Jul 28, 2024

@zingale zingale merged commit ae3a071 into AMReX-Astro:development Jul 28, 2024
25 checks passed
@zingale zingale deleted the clean_up_avisc branch July 28, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants