Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the value of g in the inputs to match the initial_models value #2883

Merged
merged 1 commit into from
Jun 24, 2024
Merged

fix the value of g in the inputs to match the initial_models value #2883

merged 1 commit into from
Jun 24, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Jun 24, 2024

also report the HSE error after reading in the model

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
fix the value of g in the inputs to match the initial_models value
cc8145e 
also report the HSE error after reading in the model
@zingale zingale merged commit 9eb8f82 into AMReX-Astro:development Jun 24, 2024
25 checks passed
@zingale zingale deleted the update_subch_hse branch June 24, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brady-ryan brady-ryan brady-ryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @brady-ryan