Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compile with shock variable support by default #2864

Merged
merged 2 commits into from
Jun 4, 2024
Merged

compile with shock variable support by default #2864

merged 2 commits into from
Jun 4, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Jun 4, 2024

this doesn't change how we burn, but makes it easier to disable burning in shocks if desired

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
compile with shock variable support by default
8a9f8bd 
this doesn't change how we burn, but makes it easier to disable
burning in shocks if desired
@zingale zingale marked this pull request as ready for review June 4, 2024 20:47
@zingale zingale merged commit 7c8e023 into AMReX-Astro:development Jun 4, 2024
25 checks passed
@zingale zingale deleted the subchandra_use_shock_var branch June 4, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhichen3 zhichen3 zhichen3 approved these changes

Assignees

@zhichen3 zhichen3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @zhichen3