Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use std::filesystem::current_path in job_info #2805

Merged
merged 2 commits into from
Mar 27, 2024
Merged

use std::filesystem::current_path in job_info #2805

merged 2 commits into from
Mar 27, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Mar 26, 2024

this eliminates a C routine with a buffer

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
use std::filesystem::current_path in job_info
627de5f 
this eliminates a C routine with a buffer
@zingale
Copy link
Member Author

zingale commented Mar 26, 2024

alternately, we could use amrex::CurrentPath() ?

@zingale zingale merged commit 52936fe into AMReX-Astro:development Mar 27, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yut23 yut23 yut23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @yut23