Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a bounds issue in sources in true SDC #2775

Merged
merged 3 commits into from
Mar 15, 2024
Merged

fix a bounds issue in sources in true SDC #2775

merged 3 commits into from
Mar 15, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Mar 14, 2024

PR summary

We were sometimes reading invalid data depending on what options were set.

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
Copy link
Member Author

zingale commented Mar 14, 2024

note: review with whitespace off, since I also fixed some formatting to make it easier to read

@zingale
Copy link
Member Author

zingale commented Mar 14, 2024

all SDC tests pass:
http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2024-03-14-003/index.html

@zingale zingale merged commit 46ece2f into AMReX-Astro:development Mar 15, 2024
22 checks passed
@zingale zingale deleted the fix_true_sdc_bounds branch March 15, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yut23 yut23 yut23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @yut23