Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CI for fsanitizer #2771

Merged
merged 4 commits into from
Mar 19, 2024
Merged

add CI for fsanitizer #2771

merged 4 commits into from
Mar 19, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Mar 9, 2024 •
edited
Loading

PR summary

This runs a 2 level 2D subchandra sim (simplified-SDC) for 1 coarse timestep with the
sanitizer enabled.

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
Copy link
Member Author

zingale commented Mar 9, 2024

this passes, but I am going to push a bug to see if it fails. Then I'll revert.

@zingale
Copy link
Member Author

zingale commented Mar 9, 2024

it fails as expected with a stack overflow and the CI test fails.

@zingale
Copy link
Member Author

zingale commented Mar 19, 2024

I just updated problem_initialize_state_data.H to loop to NumSpec+1 when filling eos_state.xn[]

@zingale zingale merged commit ae7a061 into AMReX-Astro:development Mar 19, 2024
23 checks passed
@zingale zingale mentioned this pull request Mar 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yut23 yut23 yut23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @yut23