Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug introduced in #2574 #2585

Merged
merged 1 commit into from
Sep 25, 2023
Merged

fix bug introduced in #2574 #2585

merged 1 commit into from
Sep 25, 2023

Conversation

zingale
Copy link
Member

@zingale zingale commented Sep 25, 2023

we need to access bc as a reference for inflow to override the BC type

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
fix bug introduced in AMReX-Astro#2574
2791982 
we need to access bc as a reference for inflow to override the BC type
@zingale zingale merged commit 24cf701 into AMReX-Astro:development Sep 25, 2023
18 checks passed
@zingale zingale deleted the fix_ref branch September 25, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxpkatz maxpkatz maxpkatz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @maxpkatz