Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some fixes to the true-SDC Newton solver #2580

Merged
merged 3 commits into from
Sep 25, 2023
Merged

some fixes to the true-SDC Newton solver #2580

merged 3 commits into from
Sep 25, 2023

Conversation

zingale
Copy link
Member

@zingale zingale commented Sep 24, 2023

missed these in the original density change

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
Copy link
Member Author

zingale commented Sep 24, 2023

this fixes the convergence of the Newton solver, as tested with reacting_convergence

@zingale zingale merged commit 025c1f1 into AMReX-Astro:development Sep 25, 2023
18 checks passed
@zingale zingale deleted the sdc_newton_fixes branch September 25, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxpkatz maxpkatz maxpkatz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @maxpkatz