Add CI to check runtime parameters #2577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove the "in fortran" option as well as the field from the _cpp_parameters file and also split the parser into 2 function to make it easier to build off of.
|
depends on #2576 |
|
I've verified that this will fail if it doesn't recognize something by intentionally misspelling a parameter: |
maxpkatz
approved these changes
Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This will check all of the inputs files to make sure the runtime parameters in the namespaces
defined in _cpp_parameters are all valid. Note: at the moment, we skip radiation parameters
and we also don't test on Microphysics.
This also updates problems found in existing inputs files.
PR motivation
PR checklist
CHANGESfile has been updated, if appropriate