From aa8d3b2a3bd762ac53a24e25768a4aef3a8b44fa Mon Sep 17 00:00:00 2001
From: Michael Zingale <michael.zingale@stonybrook.edu>
Date: Wed, 27 Mar 2024 08:30:04 -0400
Subject: [PATCH] a few more clang-tidy fixes (#2804)

---
 Source/driver/Castro_advance_ctu.cpp | 5 ++++-
 Source/driver/Castro_advance_sdc.cpp | 3 +++
 Source/hydro/Castro_ctu_hydro.cpp    | 5 ++++-
 Source/hydro/Castro_mol_hydro.cpp    | 4 ++++
 Source/hydro/advection_util.H        | 3 +++
 5 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/Source/driver/Castro_advance_ctu.cpp b/Source/driver/Castro_advance_ctu.cpp
index 911a2780e9..44b5cc57a8 100644
--- a/Source/driver/Castro_advance_ctu.cpp
+++ b/Source/driver/Castro_advance_ctu.cpp
@@ -12,13 +12,16 @@
 using namespace amrex;
 
 advance_status
-Castro::do_advance_ctu (Real time, Real dt)
+Castro::do_advance_ctu (Real time, Real dt)  // NOLINT(readability-convert-member-functions-to-static)
 {
     // this routine will advance the old state data (called Sborder here)
     // to the new time, for a single level.  The new data is called
     // S_new here.  The update includes reactions (if we are not doing
     // SDC), hydro, and the source terms.
 
+    amrex::ignore_unused(time);
+    amrex::ignore_unused(dt);
+
     BL_PROFILE("Castro::do_advance_ctu()");
 
     advance_status status {};
diff --git a/Source/driver/Castro_advance_sdc.cpp b/Source/driver/Castro_advance_sdc.cpp
index 83b226c7bc..01c5f653be 100644
--- a/Source/driver/Castro_advance_sdc.cpp
+++ b/Source/driver/Castro_advance_sdc.cpp
@@ -30,6 +30,9 @@ Castro::do_advance_sdc (Real time,
 
   // this is the new "formal" SDC integration routine.
 
+  amrex::ignore_unused(amr_iteration);
+  amrex::ignore_unused(amr_ncycle);
+
   // this does the entire update in time for 1 SDC iteration.
 
   BL_PROFILE("Castro::do_advance_sdc()");
diff --git a/Source/hydro/Castro_ctu_hydro.cpp b/Source/hydro/Castro_ctu_hydro.cpp
index c1a29ae0c2..0ad62f029b 100644
--- a/Source/hydro/Castro_ctu_hydro.cpp
+++ b/Source/hydro/Castro_ctu_hydro.cpp
@@ -14,8 +14,11 @@
 using namespace amrex;
 
 advance_status
-Castro::construct_ctu_hydro_source(Real time, Real dt)
+Castro::construct_ctu_hydro_source(Real time, Real dt)  // NOLINT(readability-convert-member-functions-to-static)
 {
+  amrex::ignore_unused(time);
+  amrex::ignore_unused(dt);
+
   advance_status status {};
 
   if (!do_hydro) {
diff --git a/Source/hydro/Castro_mol_hydro.cpp b/Source/hydro/Castro_mol_hydro.cpp
index 4d7e0f32db..fbcc8c6171 100644
--- a/Source/hydro/Castro_mol_hydro.cpp
+++ b/Source/hydro/Castro_mol_hydro.cpp
@@ -21,6 +21,8 @@ void
 Castro::construct_mol_hydro_source(Real time, Real dt, MultiFab& A_update)
 {
 
+    amrex::ignore_unused(time);
+
 #ifdef RADIATION
   amrex::Abort("Error: radiation not supported for the MOL hydro source term");
 #else
@@ -648,6 +650,8 @@ Castro::construct_mol_hydro_source(Real time, Real dt, MultiFab& A_update)
         }
 
         Array4<Real> pradial_fab = pradial.array();
+#endif
+#if AMREX_SPACEDIM == 1
         Array4<Real> const qex_arr = qe[0].array();
 #endif
 
diff --git a/Source/hydro/advection_util.H b/Source/hydro/advection_util.H
index 1669869dc4..cde9eaaba6 100644
--- a/Source/hydro/advection_util.H
+++ b/Source/hydro/advection_util.H
@@ -23,6 +23,9 @@ void src_to_prim(int i, int j, int k, const Real dt,
 #endif
                  Array4<Real> const& srcQ)
 {
+
+    amrex::ignore_unused(dt);
+
     for (int n = 0; n < NQSRC; ++n) {
       srcQ(i,j,k,n) = 0.0_rt;
     }