Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataSource: implement missing GetLabel method #682

Merged
merged 5 commits into from
Sep 20, 2024
Merged

DataSource: implement missing GetLabel method #682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e90866f
GenericParameters: update comment
Zehvogel Sep 19, 2024
1af1eed
DataSource add missing GetLabel override
Zehvogel Sep 19, 2024
948592f
Make comment more generic
tmadlener Sep 20, 2024
3633df1
Fix format
tmadlener Sep 20, 2024
48087e3
Remove trailing whitespace
tmadlener Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions include/podio/DataSource.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,10 @@ class DataSource : public ROOT::RDF::RDataSource {
///
std::string GetTypeName(std::string_view columnName) const override;

std::string GetLabel() override {
return "PODIO Datasource";
};

protected:
///
/// @brief Type-erased vector of pointers to pointers to column
Expand Down
2 changes: 1 addition & 1 deletion src/GenericParameters.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ GenericParameters::GenericParameters(const GenericParameters& other) :
m_stringMtx(std::make_unique<std::mutex>()),
m_doubleMtx(std::make_unique<std::mutex>()) {
{
// acquire all three locks at once to make sure all three internal maps are
// acquire all locks at once to make sure all internal maps are
// copied at the same "state" of the GenericParameters
auto& intMtx = other.getMutex<int>();
auto& floatMtx = other.getMutex<float>();
Expand Down