Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify error message in case of not implemented schema changes #483

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Clarify error message in case of not implemented schema changes #483

merged 1 commit into from
Sep 15, 2023

Conversation

hegner
Copy link
Collaborator

@hegner hegner commented Sep 15, 2023

BEGINRELEASENOTES

@tmadlener
Copy link
Collaborator

The string representation of schema_change also contains information about the involved datatype/component as well as the member, right?

@hegner
Copy link
Collaborator Author

hegner commented Sep 15, 2023

so far is has all the information. We have to make sure for the future ones that this remains the case.

tmadlener
tmadlener approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I think that is somewhat easy to do by just following what the current class structure does.

@hegner
Copy link
Collaborator Author

hegner commented Sep 15, 2023

that's the hope :)

@hegner hegner merged commit d402f74 into master Sep 15, 2023
17 checks passed
@hegner hegner deleted the schema-comments branch September 15, 2023 12:14
Ananya2003Gupta pushed a commit to Ananya2003Gupta/podio that referenced this pull request Sep 26, 2023
@hegner @Ananya2003Gupta
clarify error message in case of not implemented schema changes (AIDA…
28b0644 
…Soft#483)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hegner @tmadlener