Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphviz needs to be in requirements.txt #637

Closed
tmadlener opened this issue Jul 9, 2024 · 2 comments · Fixed by #660
Closed

graphviz needs to be in requirements.txt #637

tmadlener opened this issue Jul 9, 2024 · 2 comments · Fixed by #660
Labels
bug dependencies Pull requests that update a dependency file documentation good first issue

Comments

@tmadlener
Copy link
Collaborator

podio-vis needs graphviz. If it is not there some tests will fail. We need to document this and also put graphviz into the requirements.txt file.

@tmadlener tmadlener added bug documentation dependencies Pull requests that update a dependency file good first issue labels Jul 9, 2024
@m-fila
Copy link
Contributor

m-fila commented Jul 9, 2024

As for the documentation it's already mentioned in the README

podio/README.md

Lines 75 to 78 in 1fc075d

Some tools have additional dependencies that are not required for code generation or library use
- `graphviz` is required for `podio-vis`
- `tabulate` is required for `podio-dump`

@tmadlener
Copy link
Collaborator Author

Yes, but apparently people don't read that ;) This also ties in a bit with #474 if we want to do it "properly"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file documentation good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants