Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup CollectionReadBuffers #506

Open
tmadlener opened this issue Oct 13, 2023 · 1 comment
Open

Cleanup CollectionReadBuffers #506

tmadlener opened this issue Oct 13, 2023 · 1 comment
Assignees

Comments

@tmadlener
Copy link
Collaborator

This is a follow up to #502 which implemented a quick fix. Ideally the CollectionReadBuffers are refactored to a (move-only) type that clearly indicates the ownership of the contained buffers. Something like a unique_ptr with a custom (type-erased) deleter should work in this case, since we can populate the deleters at generation time.

@tmadlener tmadlener self-assigned this Oct 13, 2023
@tmadlener
Copy link
Collaborator Author

Enabling AddressSanitizer also reveals that there are a couple of indirect leaks in the whole machinery at the moment that could be related to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant