Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDSim argument gun.energy is actually the total energy, not kinetic energy #1177

Closed
atolosadelgado opened this issue Oct 14, 2023 · 3 comments
Labels

Comments

@atolosadelgado
Copy link
Contributor

Hi,

The DDSim argument gun.energy is actually the total energy (kinetic+mass). However, the text that is displayed says only kinetic.

ddsim --help | grep -B 1 kinetic
  --gun.energy GUN.ENERGY
                        The kinetic energy for the particle gun.

Would you prefer to change the description of the input parameter, or the behavior of it (summing the mass of the gun particle internally)?

Best,
Alvaro

@MarkusFrankATcernch
Copy link
Contributor

Ciao Alvaro,
Please, if you can spare a minute simply fix the printout and submit a MR.
I think this is easiest and backwards compatible. For most practical purposes the
kinectic energy in HEP is anyhow way off higher then the mass of (mostly stable) particles.
Thanks!
Markus

@atolosadelgado
Copy link
Contributor Author

Ready, #1179

Maybe it is worth to add an exception, in case someone by mistake try to run an energy below the mass. The simulation simply actually runs if the given energy is below the mass of the particle gun.

@MarkusFrankATcernch
Copy link
Contributor

@atolosadelgado Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants