Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to give CAD files with relative paths similar to importing xml files (DDCAD) #1166

Closed
armin-ilg opened this issue Sep 6, 2023 · 3 comments
Labels
enhancement Fixed Problem is solved Testing Waiting for caller Waiting for issue opener to respond to question

Comments

@armin-ilg
Copy link

Hi

As discussed with @andresailer in key4hep/k4geo#273 (comment), it would be great if CAD files could be imported using DDCAD giving relative paths as it is done for xml files.
So instead of having to give an absolute path:

<shape type="CAD_MultiVolume" ref="${K4GEO}/share/k4geo/FCCee/IDEA/compact/IDEA_o1_v01/VertexSupport_o1_v01.obj" unit="mm"/>

I would like to give a relative path from the parent xml file:

<shape type="CAD_MultiVolume" ref="VertexSupport_o1_v01.obj" unit="mm"/>

which should work independently of the current working directory.

In the current DDCAD examples (e.g Check_Shape_MS3D_jeep.xml) there are always absolute paths given.

Let me know if I'm not clear, thank you!

Armin

@MarkusFrankATcernch
Copy link
Contributor

See PR: #1175

@MarkusFrankATcernch MarkusFrankATcernch added Testing Fixed Problem is solved Waiting for caller Waiting for issue opener to respond to question labels Oct 19, 2023
@MarkusFrankATcernch
Copy link
Contributor

Once you have checked that this issue is fixed by PR 1175, please close the issue.

@armin-ilg
Copy link
Author

It's working, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Fixed Problem is solved Testing Waiting for caller Waiting for issue opener to respond to question
Projects
None yet
Development

No branches or pull requests

2 participants