Add seat model check #393
Merged
Add seat model check #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The KeShove test is the only test failing, which isn't related to my changes(?) so I'm making this ready for review |
This will only allow the seat to fail its model legal check if its model does not match the one it has listed in its VehicleTable, which should avoid any potential incompatibility with other addons by ensuring that you can only fail if something intentionally changes the seat model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, seat models can be anything, including microscopic models (such as Wiremod's "nano_compare" gate). I've seen this exploited in the real world to get very hard to kill seats.
This adds a seat model whitelist to only allow default HL2, ACF, playerstart and racing seat models.
You can see a wooden chair vs. a nano compare in terms of size:
