Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen the dependency to avoid conflict with other package #588

Closed
chiang-yuan opened this issue Sep 12, 2024 · 8 comments
Closed

Loosen the dependency to avoid conflict with other package #588

chiang-yuan opened this issue Sep 12, 2024 · 8 comments

Comments

@chiang-yuan
Copy link
Contributor

@ilyes319 could we loosen the dependency of e3nn to e3nn>=0.4.4

mace/setup.cfg

Line 18 in 22a2e3e

e3nn==0.4.4

@ilyes319
Copy link
Contributor

Can you try locally updating to the latest e3nn and see if everything training works.

@chiang-yuan
Copy link
Contributor Author

chiang-yuan commented Sep 12, 2024

I am trying to wrap a pyproject.toml dependency. e3nn is the only one causing the problem. Locally updating is possible for user but not package wrapping unfortunately. :( Any reason that later version of e3nn is not working / unsafe?

@ilyes319
Copy link
Contributor

I meant can you confirm that locally e3nn latest version works fine?

@chiang-yuan
Copy link
Contributor Author

Not sure at this moment. I could update locally and try training for the next model. Another way is test workflow? Is there anything missing in the test that we should probably add?

@ilyes319
Copy link
Contributor

big missing part in the testing workflow atm are training with h5 files and multigpu (that one we can't not really test).

@chiang-yuan
Copy link
Contributor Author

I see. I will try adding offline testing script and small demo data. And pick up #452 and solve it altogether

@chiang-yuan
Copy link
Contributor Author

related to #555

@ilyes319
Copy link
Contributor

ilyes319 commented Oct 1, 2024

I figured something changed in the Clebsch Gordan convention between 0.4.4 and 0.5.1 that breaks backward compatibility with foundation models so I will keep the pin for e3nn for now.

@ilyes319 ilyes319 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants