Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify System setup #34

Open
cortner opened this issue Aug 22, 2023 · 2 comments
Open

Simplify System setup #34

cortner opened this issue Aug 22, 2023 · 2 comments

Comments

@cortner
Copy link
Member

cortner commented Aug 22, 2023

The tutorial in ACEpotentials seems more complicated than necessary. The lines

data = FastSystem(ExtXYZ.Atoms(read_frame("initial structure in xyz file")))
atoms = [Molly.Atom( index=i, mass=AtomsBase.atomic_mass(data, i) ) for i in 1:length(data) ]
boundary = begin
    box = bounding_box(data)
    CubicBoundary(box[1][1], box[2][2], box[3][3])
end
atom_data = [ (; :Z=>z,:element=>s)  for (z,s) in zip(AtomsBase.atomic_number(data), AtomsBase.atomic_symbol(data))  ]

seem completely generic and could be wrapped into a convenience wrapper?

I'm not certain if that wrapper should be here or elsewhere though. This seems to have nothing to do with ACEmd or ACEpotentials? Maybe in AtomsBase?

@tjjarvinen
Copy link
Collaborator

This is to deal with Molly. So, Molly would also be the correct address for this.

I can do some fixing in ACEmd, but I need to make a PR in Molly to fix them properly.

@cortner
Copy link
Member Author

cortner commented Aug 22, 2023

then let's do it properly and go straight to Molly? Thanks for looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants