Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site descriptors for a subset of atoms #80

Open
siasolt opened this issue Nov 6, 2023 · 2 comments
Open

Site descriptors for a subset of atoms #80

siasolt opened this issue Nov 6, 2023 · 2 comments

Comments

@siasolt
Copy link

siasolt commented Nov 6, 2023

Is it possible to compute ACE descriptors for a subset of atoms instead of all atoms in a simulation box?

site_descriptors(basis, atoms) extracts the feature vector for all atoms.

@cortner
Copy link
Member

cortner commented Nov 6, 2023

There is this:

site_descriptor(basis, atoms::AbstractAtoms, i::Integer)

which returns a single one. Since site_descriptors just broadcasts this one, I think you could just do one of the following:

[ site_descriptor(basis, atoms, i) for i in list] 
site_descriptor.(Ref(basis), Ref(atoms), list)

But it would be nice to have syntax for this, basically,

site_descriptors(basis, atoms, list) 

or something similar. Do you feel like making a PR?

@cortner
Copy link
Member

cortner commented Nov 6, 2023

actually it should be a very quick fix. I'll do this and let you know when it's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants