Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional directives should be added to the interpolation context. #17

Closed
bschroeter opened this issue Aug 22, 2024 · 0 comments · Fixed by #18
Closed

Additional directives should be added to the interpolation context. #17

bschroeter opened this issue Aug 22, 2024 · 0 comments · Fixed by #18
Assignees

Comments

@bschroeter
Copy link
Collaborator

Walltime, storage and queue arguments need to be added to the interpolation context as well as being added as command flags.

hpcpy/hpcpy/client.py

Lines 332 to 343 in 0a7250a

if queue:
directives.append(f"-q {queue}")
# Add walltime
if walltime:
_walltime = str(walltime)
directives.append(f"-l walltime={_walltime}")
# Add storage
if storage:
storage_str = "+".join(storage)
directives.append(f"-l storage={storage_str}")

This may be associated with #16, but at least in the first instance should be copied to the interpolation context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant