Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload Build Provenance Metadata #63

Merged
merged 19 commits into from
May 15, 2024
Merged

Upload Build Provenance Metadata #63

merged 19 commits into from
May 15, 2024

Conversation

CodeGat
Copy link
Contributor

@CodeGat CodeGat commented May 2, 2024 •
edited
Loading

In this PR:

  • Addition of hashes to spack.location.json
  • Addition of new repo secrets: BUILD_DB_CONNECTION_STR
  • Addition of new vars: BUILD_DB_PACKAGES
  • Move non-deploy logic out of deploy-to-environment job
  • Added tests for new scripts

Closes #33

@CodeGat CodeGat self-assigned this May 2, 2024
@CodeGat CodeGat force-pushed the 33-released-builds-to-db branch 2 times, most recently from 49644f3 to 2012435 Compare May 8, 2024 06:16
@CodeGat CodeGat marked this pull request as ready for review May 8, 2024 06:21
@CodeGat CodeGat marked this pull request as draft May 9, 2024 03:44
@CodeGat CodeGat marked this pull request as ready for review May 9, 2024 23:01
aidanheerdegen
aidanheerdegen requested changes May 14, 2024
View reviewed changes
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry!

tests/scripts/generate-build-metadata/valid/cice5.json Outdated Show resolved Hide resolved
tests/scripts/generate-build-metadata/valid/cice5.json Outdated Show resolved Hide resolved
@aidanheerdegen aidanheerdegen mentioned this pull request May 14, 2024
Merged
aidanheerdegen
aidanheerdegen approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's give this a burl!

@CodeGat CodeGat merged commit 9274bd6 into main May 15, 2024
2 checks passed
@CodeGat CodeGat deleted the 33-released-builds-to-db branch May 15, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utkarshgupta95 utkarshgupta95 utkarshgupta95 left review comments

@aidanheerdegen aidanheerdegen aidanheerdegen approved these changes

Assignees

@CodeGat CodeGat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Report released builds to DB for provenance
3 participants
@CodeGat @aidanheerdegen @utkarshgupta95