-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This method apperently doesn't work anymore #3
Comments
It appears with newer Android 13 the overlay needs to be installed to |
Here is an example change I made to the build script to create a package that'll install the overlay to the new path. The generated Magisk module also works with KernelSU. I'm not sure about the compatibility with older Android versions when using |
Hi, I would like to try your updated version on /e/OS based LOS 20 (A13) using the custom recovery method and I see you made the changes to your script about a week ago but v0.1 is from March 17. Where your changes included in v0.1 ? Thanks |
I'm tracking this change on a separate branch in my own fork, as I do not know if this breaks Android 12 and earlier support. If older Android versions (preferably from 10 and onwards) can still work this way I could consider making a PR. I only changed the |
Hmmm... if you're using custom recovery method instead of Magisk/KSU then I'm afraid I need to make some changes to EDIT: The |
I've just added some more changes in my Will now produce two different variants of packages, one for Testing needed for non-Magisk/KSU packages as I'm not sure if changes to |
I really like your rootless overlay approach, as you wrote in your notes it's indeed clean and elegant. I personally try to avoid Magisk if I can, eventhough it does wonders... at some risk.
|
Here it is. With my latest changes, there will be two sets of generated packages: I can't test the recovery packages for you, as I don't want to make changes to |
As far as I'm understand, running build.sh will generate the necessary modules right? I'm a newbie at linux |
Ok needs to be installed manually. Won't go there as if there's an issue not sure will be able to revert to previous stage, so will leave it there. Thanks anyway! |
Yes, that's all you need. If the script finishes without issues, collect the modules in the
I don't think it would cause too much harm, as it involves only a single file that would be the overlay. The problem is, you'll definitely have to rely on the module (Magisk/KSU), if your system partitions cannot be made r/w. If you install it from recovery (such as Lineage's) you need to do so via If your device happens to have a usable TWRP you may flash the zip directly from there after putting it into your phone storage. I haven't changed the README file yet. The only difference from the original instructions would be to choose the one with |
Which variant are you using? On the other hand... I tried your command on my own device but I don't see the entry... hmmm... Maybe it's because I'm on KernelSU? EDIT: You should refer to the output of this command.
See if it has a line mentioning about |
I think you've installed a Bromite WebView overlay before, which took priority over Mulch overlay so it cannot work. Disable any other WebView overlay module you've installed, and see if it makes any difference. |
The commands you're using are not reliable. |
An update on this. If you're using phh-based GSI this built-in overlay which included Bromite support back then may have conflicted with this, and probably explained why you have a Bromite entry in the list of WebViews. I'll be downloading and inspecting the GSI build you mentioned to see if this applies. It's been a while since I used new GSIs and I kinda forgot about it. EDIT: Confirmed. I've filed an issue there. A possible workaround would be to override (replace) the existing overlay ( |
Can confirm @lss4's |
Can also confirm it works on /e/OS 2.1 (A13), as a Magisk module. |
I have used both method (magisk and just the overlay zip) on 2 different devices, both run Android 13 QPR3. I contact rom developers and they doesn't change anything. It indeed worked on QPR2 so I guess Google do something that change the overlay in QPR3. Another module relies on overlay (open-webview) also doesn't work.
The text was updated successfully, but these errors were encountered: