Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Biome as a formatter and linter #81

Closed
7nohe opened this issue Apr 21, 2024 · 1 comment · Fixed by #104
Closed

Biome as a formatter and linter #81

7nohe opened this issue Apr 21, 2024 · 1 comment · Fixed by #104
Assignees
@7nohe
Labels
enhancement New feature or request

Comments

@7nohe
Copy link
Owner

7nohe commented Apr 21, 2024

Currently, @hey-api/openapi-ts is also trying to support Biome.
I think it should be ok to use Biome for the root of the project. #76
@7nohe 7nohe added the enhancement New feature or request label Apr 21, 2024
@7nohe 7nohe self-assigned this Apr 21, 2024
@seriouslag seriouslag mentioned this issue Apr 22, 2024
Merged
@seriouslag
Copy link
Collaborator

seriouslag commented Apr 22, 2024 •
edited
Loading

Opened PR, #84, to update @hey-api/openapi-ts to a version that supports Biome.

seriouslag added a commit that referenced this issue Apr 22, 2024
@seriouslag
chore(deps): update @hey-api/openapi-ts to 0.42.1
f70fd02 
- Update to the latest `@hey-api/openapi-ts` version `0.42.1`
- Fixed a bug where types in mutation hooks were imported from a (non-relative) direct file import.
    - This is the same fix implemented in #61, which was done for query hooks.
- Fixed a bug where JSDocs were not being added to generated hooks.
- Add more unit tests

Fixes: #83
Enables work towards: #81
seriouslag added a commit that referenced this issue Apr 23, 2024
@seriouslag
In this PR:
751c6ed 
- Update to the latest `@hey-api/openapi-ts` version `0.42.1`
  - fixes: #83,
  - Enables work towards #81
- Fixed a bug where types in mutation hooks were imported from a (non-relative) direct file import.
    - This is the same fix implemented in #61, which was done for query hooks.
    - Expand the match regex to take account of non-alphabetical file paths
      - fixes: #85
- Fixed a bug where JSDocs were not being added to generated hooks.
- Add more unit testing
@7nohe 7nohe mentioned this issue May 3, 2024
Merged
@7nohe 7nohe closed this as completed in #104 May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@7nohe 7nohe

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Add Biome as a formatter and linter 7nohe/openapi-react-query-codegen
2 participants
@7nohe @seriouslag