Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tab change & reload page issue (Change base branch to dspace-cris-2023_02_x) #91

Open
wants to merge 2 commits into
base: dspace-cris-2023_02_x
Choose a base branch
from

Conversation

oye816
Copy link

@oye816 oye816 commented May 7, 2024

References

Add references/links to any related issues or PRs. These may include:

Description

Fix tab change & reload page issue

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

  • Fix Open a researcher profile → Choose the CRIS tab for Publications → Select a search filter → Switch to a different tab for Projects will display incorrect search data issue.
  • Fix Open a researcher profile → Choose the CRIS tab for Publications → Select a search filter → Reload webpage will display incorrect search data issue.

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

oye816 added 2 commits May 7, 2024 16:45
* dspace-cris-2023_02_x:
  [DSC-880] port fix to hide tab
  CST-7885 hide relationship tab in administer item
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant