Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix of issue #82 #83

Open
wants to merge 3 commits into
base: main-cris
Choose a base branch
from
Open

bugfix of issue #82 #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a11268d
improve robustness of formatText
saschaszott Mar 20, 2024
a9923f9
workaround to fix NullInjectorError
saschaszott Mar 20, 2024
ca9be92
fixed lint error
saschaszott Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ut-box-container/boxes/metadata/rendering-types/metadataGroup/metadata-group.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export abstract class MetadataGroupComponent extends RenderingTypeStructuredMode
this.metadataGroup.forEach(mdg => {
const entry = {
field: mdg,
value: this.getMetadataValue(mdg, index)
value: this.getMetadataValue(mdg, index) || ' '
} as NestedMetadataGroupEntry;
if (this.componentsToBeRenderedMap.has(index)) {
const newEntries = [...this.componentsToBeRenderedMap.get(index), entry];
Expand Down
3 changes: 3 additions & 0 deletions ...ix/cris-layout-box-container/boxes/metadata/rendering-types/rendering-type-value.model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ export abstract class RenderingTypeValueModelComponent extends RenderingTypeMode
* @param text
*/
formatText(text: string): string {
if (!text) {
return text;
}
const newlineRegex = /\n/g;
return text.replace(/>/g, '&gt;').replace(/</g, '&lt;').replace(newlineRegex, '<br>');
}
Expand Down