Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pagination on external sources #62

Open
wants to merge 11 commits into
base: dspace-cris-2023_02_x
Choose a base branch
from

Conversation

floriangantner
Copy link

References

Description

Set the paginationId on external sources lists. Otherwise the pagination should not work.

Instructions for Reviewers

  • try to import external sources without this change (it's only one line). By more than 10 entries the pagination should not work
  • retry this with the applied patch. The pagination should work

List of changes in this PR:

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

davide-negretti and others added 11 commits November 27, 2023 11:25
[DSC-1408] - Fix dropdown readonly field

Approved-by: Andrea Barbasso
# Conflicts:
#	src/config/default-app-config.ts
#	src/environments/environment.test.ts
[DSC-1352] Move breadcrumb char limit property inside layout configuration properties

Approved-by: Andrea Barbasso
DSC-1037

Approved-by: Giuseppe Digilio
@floriangantner floriangantner changed the base branch from dspace-cris-7 to dspace-cris-2023_02_x April 9, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing from external sources - pagination fail
5 participants