Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Associate Item Frontend #50

Draft
wants to merge 5 commits into
base: dspace-cris-2023_02_x
Choose a base branch
from

Conversation

floriangantner
Copy link

@floriangantner floriangantner commented Sep 1, 2023

References

Add references/links to any related issues or PRs. These may include:

Description

basic functionality to associate two items. own page with search and list preview with action buttons, services to trigger. associateitemmodes are being used to check the access to the page and to show the context-menu button. In the majority some adoption of the edititem, edititem-mode and edit-relationship functionality.

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

  • First, ...
  • Second, ...

Counterpart Backend:
4Science/DSpace#382

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

  • based on the default configuration (see backend PR Draft: AssociateItem Backend DSpace#382) the following steps can be performed:
  • Open project where the logged in user profile is in cris.investigator field
  • Wait for context-menu button to be shown
  • Open Button
  • Associate some publications and disassociate some publications
  • See result of the actions in the regarding relation tab of the publication.
  • Test the scenario with further conditions

Screenshot 2023-09-01 at 18-07-14 Bildungsverläufe am Ende der Sekundarstufe aus soziologischer und psychologischer Perspektive (Prof  Artelt)

Screenshot 2023-09-01 at 18-06-34 Connect Publication

Screenshot 2023-09-01 at 18-06-45 Connect Publication

Screenshot 2023-09-01 at 18-07-04 Connect Publication

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

basic functionality to associate two items. own page with search and list preview with action buttons, services to trigger. associateitemmodes are being used to check the access to the page and to show the context-menu button. In the majority some adoption of the edititem, edititem-mode and edit-relationship functionality.
@floriangantner floriangantner changed the base branch from dspace-cris-7 to main-cris February 20, 2024 15:07
@floriangantner floriangantner changed the base branch from main-cris to dspace-cris-2023_02_x April 9, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant