Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explore menu icons #49

Conversation

floriangantner
Copy link

@floriangantner floriangantner commented Aug 23, 2023

additional icon for explore menus. The menu entry can be some internal or external link with an additional icon. The icon can be configured for each explore_section

References

Description

Short summary of changes (1-2 sentences).

  • some additonal icon can be included in explore menus
  • the icon can be configured in default-app.config.ts
  • the icon works on internal routes as well as external links
  • additional css classes can be configured in the icon to style the icon.

Instructions for Reviewers

configure icon

Screenshot from 2023-08-23 17-57-42

Screenshot 2023-08-23 at 18-02-00 The Official DSpace-CRIS 7 Demo Startseite

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

additional icon for explore menus. The menu entry can be some internal or external link with an additional icon. The icon can be configured for each explore_section
@floriangantner floriangantner changed the title graphical explore menu icons explore menu icons Aug 23, 2023
@dominik-kern
Copy link

This is a nice feature, but how to add an icon to communities_and_collections which is not an explore_section?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

icons in main navigation menu
2 participants