Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collection browse search results might show loader #70

Open
floriangantner opened this issue Feb 7, 2024 · 0 comments
Open

collection browse search results might show loader #70

floriangantner opened this issue Feb 7, 2024 · 0 comments
Labels

Comments

@floriangantner
Copy link

Describe the bug
If no browse index is configured for someCollection and dc.date.accessioned is not configured as some sorting in the default/common configuration the sorting for some collection browse will always show the loader.

To Reproduce
Steps to reproduce the behavior:

  1. Configure browse.collection.Publication = and browse.collection =
  2. remove sortDateAsseccioned from defaultConfiguration or commonConfiguration.
  3. Call collection page

Screenshot 2024-02-07 at 16-41-41 Publications

Expected behavior
Dear reader of this issue, do not pay too much attention to our above mentioned configuration. We expect the browsing showing some error message when the retrieved searchresults from the search endpoint contains some error and not continously showing the loader.

This can be achieved by some check of the response here:

.pipe(toDSpaceObjectListRD()) as Observable<RemoteData<PaginatedList<Item>>>;

Apart from that it would be some nice feature to have the ability to disable the recent submission on the collection page by some environment setting, but this is not part of this issue.

Related work

Link to any related tickets or PRs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant