Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authorize-check for xlscollectionCrosswalk #432

Open
wants to merge 1 commit into
base: main-cris
Choose a base branch
from

Conversation

floriangantner
Copy link

References

Description

Implement interface method for fine granular check to export these crosswalks to specific groups

Instructions for Reviewers

List of changes in this PR:

  • implement isAuthorized method, which was before by default true by the interface ItemExportCrosswalk
    • add group check copied from other Crosswalk Formats
  • whitebox-Tests: depending on the configuration check if the crosswalk format is offered to Anonymous/Administrator users in the context-menu.
  • Introduced new IntegrationTest to check the isAuthorized function
  • configuration: allow access to Administrator and Anonymous (behavior as before)
	<bean class="org.dspace.content.integration.crosswalks.XlsCollectionCrosswalk" id="xlsCrosswalkCollection">
		<property name="allowedGroups">
			<list>
				<value>Administrator</value>
				<value>Anonymous</value>
			</list>
		</property>
	</bean>

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
  • My PR passes Checkstyle validation based on the Code Style Guide.
  • My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
  • My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
  • If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

implement interface method for fine granular check to export these issues only to Administrator group. Configured crosswalk to stay to the current behaviour (export to all)
4Science#422
@floriangantner floriangantner changed the base branch from main-cris to dspace-cris-2023_02_x April 9, 2024 09:59
@floriangantner floriangantner changed the base branch from dspace-cris-2023_02_x to main-cris April 9, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

limit xls-collection-crosswalk to group members
1 participant