Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabled option in create application plan doesn't work as expected #335

Open
lucamaf opened this issue Sep 30, 2021 · 5 comments
Open

disabled option in create application plan doesn't work as expected #335

lucamaf opened this issue Sep 30, 2021 · 5 comments

Comments

@lucamaf
Copy link

lucamaf commented Sep 30, 2021

Just applied this command:
3scale application-plan create --disabled --system-name=finnhub_crypto acme-ocp4 6 "crypto basic"
and the only method/metric that was disabled during configuration was Hits, the rest which are not default, but come with the Product are enabled

@eguzki
Copy link
Member

eguzki commented Sep 30, 2021

you are talking about metrics/methods in the Product, right? Because, now looking at the code, I would expect to miss the backend metrics/methods because it was developed before backends were implemented and this command was not updated to support backends.

@lucamaf
Copy link
Author

lucamaf commented Sep 30, 2021

correct, I'm speaking about application plan of a product

@eguzki
Copy link
Member

eguzki commented Oct 4, 2021

The limits and pricingrules defined in the application plan belong to the product or to some backend?

@lucamaf
Copy link
Author

lucamaf commented Oct 5, 2021

they belong to the product

@eguzki
Copy link
Member

eguzki commented Oct 5, 2021

reproduced! thanks for the report. Only metrics are being "disabled". Methods are not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants