pyproject.toml: Move metadata here from setup.py #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| requires = [ | ||
| "setuptools>=61.2", |
There was a problem hiding this comment.
This is causing the CI failure since Python 3.6 does not support setuptools > 60.10.
There was a problem hiding this comment.
Hm... do you plan to keep support for Python 3.6?
There was a problem hiding this comment.
We should probably drop support for 3.6, but would want to do that simultaneously for all of snappy's various components. I suggest changing to setuptools>=59.6 unless you're using some newer feature.
There was a problem hiding this comment.
Support for metadata in pyproject.toml was added in setuptools 61 I think,
and the [tool.setuptools] section is out of beta only since 68.1.0.
There's no urgency here.
|
I think the answer depends on which version of Python comes with the old
version of Red Hat that runs on a typical cluster, where the one at UIUC is
typical.
- Marc
…On Sun, Feb 18, 2024 at 9:00 PM Matthias Köppe ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pyproject.toml
<#56 (comment)>
:
> \ No newline at end of file
+requires = [
+ "setuptools>=61.2",
Hm... do you plan to keep support for Python 3.6?
—
Reply to this email directly, view it on GitHub
<#56 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ6CPY3O6C2M3UCDKKLWH3YUK55PAVCNFSM6AAAAABDNYXODCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQOBXGQ3TAOBZGI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To modernize metadata while I'm at it for other projects