Unsuccessful standby replication on PostgreSQL 17

[esiaero]

Hi, I tested subscription to a standby with the HEAD of the repo (pglogical 2.4.5, pending release).
I'm noticing pglogical seems to create subscriptions with failover as long as its supported on the node (by checking catalog).

pglogical/pglogical_sync.c

Lines 900 to 904 in c3507a8

	use_failover_slot =
	pglogical_remote_function_exists(origin_conn, "pg_catalog",
	"pg_create_logical_replication_slot",
	-1,
	"failover");

pglogical/pglogical_sync.c

Lines 308 to 311 in c3507a8

	#if PG_VERSION_NUM >= 170000
	appendStringInfo(&query, "CREATE_REPLICATION_SLOT \"%s\" LOGICAL %s%s",
	slot_name, "pglogical_output",
	use_failover_slot ? " (FAILOVER)" : "");

But with PG 17, that isn't supported if its a standby.
https://github.com/postgres/postgres/blob/bccca780eef904002512a1a0b5ce617bcb63507b/src/backend/replication/slot.c#L330-L333

So unlike PG 16, now the subscription cannot succeed, with error messages like

ERROR:  cannot enable failover for a replication slot created on the standby
...
STATEMENT:  CREATE_REPLICATION_SLOT "pgl_postgres_provider_testsub" LOGICAL pglogical_output (FAILOVER)

I was curious if this kind of behavior is expected?

[eulerto]

Fixed by commit 8579de3.