E2e tests #65
E2e tests #65
Conversation
rperez89
requested review from
lkngtn,
0xGabi,
willjgriff,
fabriziovigevani and
yeqbfgxjiq
.circleci/config.yml
Outdated
| keys: | ||
| - redemptions-{{ checksum "package.json" }} | ||
| # fallback to using the latest cache if no exact match is found | ||
| # - redemptions- | ||
|
|
There was a problem hiding this comment.
can we add restore_cache back again?
There was a problem hiding this comment.
there is some kind of problem installing websocket when you have the restore_cache, we need to investigate it a little more
package.json
Outdated
| "openzeppelin-solidity": "2.0.1", | ||
| "@babel/plugin-proposal-object-rest-spread": "^7.3.4", | ||
| "@babel/polyfill": "^7.2.5", | ||
| "@babel/register": "^7.0.0", |
There was a problem hiding this comment.
duplicated, already in devDependencies
There was a problem hiding this comment.
perfect, will remove it
| # CircleCI maintains a library of pre-built images | ||
| # documented at https://circleci.com/docs/2.0/circleci-images/ | ||
| # - image: circleci/mongo:3.4.4 | ||
| - image: circleci/node:lts |
There was a problem hiding this comment.
We decided to use circleci/node:8.15.1 so the restore-cache works
| coverage: | ||
| docker: | ||
| # specify the version you desire here | ||
| - image: circleci/node:lts |
There was a problem hiding this comment.
| - image: circleci/node:lts | |
| - image: circleci/node:8.15.1 |
| - redemptions-{{ checksum "package.json" }} | ||
| # fallback to using the latest cache if no exact match is found | ||
| # - redemptions- | ||
|
|
There was a problem hiding this comment.
We can add this back again and use restore_node_modules
so it would be
- *restore_node_modules
|
This is a really cool project. Are we still moving forward on this and/or what are the blockers? |
|
We decided to leave it hangin for a while due to taking too much time to process and sometimes it would run out of memory. @0xGabi was working on something to have the wrapper already pre-built which can help us on this matter. |
|
Just came across Ghost Inspector, which is essentially a paid service to use an automated browser (probably also Puppeteer or Phantom or whatever) to test website builds. It's paid (and probably not open source) so probably not the best choice for us, but seemed kind of similar to what you're building so I thought I'd share. On that note, would it make sense to move this e2e testing framework into the devops repo rather than having it as something specific to Redemptions? |
We can take a look to that tool! this is just a PR with the coiding of that e2e test that i did, but we never merge it because is too heavy for the CircleCi basic plan |
|
Hey since |
E2E test with automatic visual test execution using puppeteer and percy integration