Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only one script to both deploy tokens and run the app #93

Open
0xGabi opened this issue Sep 26, 2019 · 1 comment
Open

Use only one script to both deploy tokens and run the app #93

0xGabi opened this issue Sep 26, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@0xGabi
Copy link
Member

0xGabi commented Sep 26, 2019

I think the solution that @ajsantander made for his app is more intuitive and practic than what we currently have. Check the code here

@0xGabi 0xGabi added the enhancement New feature or request label Sep 26, 2019
@fabriziovigevani
Copy link
Member

I think the use case is different. In the implementation you provided you need to have token addresses already deployed so you can initialize your app with said addresses.

In our case we need the DAO address as argument to the truffle script so we need to wait for the aragon run command to finish. I think would be way easier to have it in one command but not really sure how to pipe the DAO address to another process and still show all aragon run output.

Maybe @ajsantander you have some suggestions? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants