Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding: when approving the HNY tokens use the price from the oracle #494

Open
0xGabi opened this issue Dec 22, 2021 · 0 comments
Open
Labels
🐛 bug Something isn't working

Comments

@0xGabi
Copy link
Member

0xGabi commented Dec 22, 2021

Otherwise, sometimes the first transaction revets with a TRANSFER_FROM error. This is because the approved amount of HNY is not enough given the consulted price by the oracle. Instead, use the price from the oracle to check if it's above the $100.

Example tx that failed: https://dashboard.tenderly.co/tx/xdai/0xf1fc8feb1e93381f067066d88f9bf12a24116fc062d03059f38399e10bf1944d

The transaction says the user wants to lock 0.5500390068140331 HNY though input was 0.55 HNY

@0xGabi 0xGabi added the 🐛 bug Something isn't working label Dec 22, 2021
@0xGabi 0xGabi moved this to 📑 Backlog in Gardens 🌻 Jan 18, 2022
@0xGabi 0xGabi moved this from 📑 Backlog to 🔥 Next in Gardens 🌻 Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
No open projects
Status: 🔥 Next
Development

No branches or pull requests

1 participant