Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint: Need active react hooks plugin #758

Open
kamikazebr opened this issue Dec 27, 2021 · 1 comment
Open

Eslint: Need active react hooks plugin #758

kamikazebr opened this issue Dec 27, 2021 · 1 comment
Labels
👷‍♀️ DX Developer experience issues

Comments

@kamikazebr
Copy link
Member

kamikazebr commented Dec 27, 2021

Eslint its all good to keeping avoid bug before that happens.

We already have eslint-plugin-react-hooks, but need active/configure properly to work

We need add

rules: {
    'react-hooks/rules-of-hooks': 'error',
    'react-hooks/exhaustive-deps': 'warn',
  },

To eslintrc.js

After activing i got 1 errors and 3 warning. One printscreen to sample below

image

The error need be fix after activing it.

That's simple task.

I recommend do that it after #749 be merged

@kamikazebr kamikazebr self-assigned this Dec 27, 2021
@0xGabi 0xGabi added the 👷‍♀️ DX Developer experience issues label Jan 5, 2022
@0xGabi
Copy link
Member

0xGabi commented Jan 5, 2022

Let's wait for the migration to NextJS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👷‍♀️ DX Developer experience issues
Projects
None yet
Development

No branches or pull requests

2 participants