Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revoked hosted assertions shown as valid in validator #236

Open
rubenmch opened this issue Nov 8, 2020 · 1 comment · May be fixed by #246
Open

Revoked hosted assertions shown as valid in validator #236

rubenmch opened this issue Nov 8, 2020 · 1 comment · May be fixed by #246

Comments

@rubenmch
Copy link

rubenmch commented Nov 8, 2020

The Open Badges documentation states:

If either the 410 Gone status or a response body declaring revoked true is returned, the Assertion should be treated as revoked and thus invalid.

I'm testing an assertion with both 410 status and revoked = true and it's shown as valid in the validator.

https://jhpdn65dri.execute-api.us-east-1.amazonaws.com/Prod/certificado/f7e372de-c1b8-43f7-b13c-70f672bc18f2.json

image

image

@rubenmch rubenmch changed the title Revoked hosted assertions with status 200 shown as valid in validator Revoked hosted assertions shown as valid in validator Nov 8, 2020
@rubenmch
Copy link
Author

Also, there's a mismatch between how revoked assertions are shown by the validator for hosted and signed assertions.

Hosted revoked assertions are shown as valid but signed revoked assertions are shown as not valid with the following error message:

"report": {
        "openBadgesVersion": "2.0",
        "errorCount": 1,
        "warningCount": 0,
        "validationSubject": "urn:uuid:39d90b25-5ddb-4518-8f05-1ac74f1c1f91",
        "messages": [
            {
                "messageLevel": "ERROR",
                "node_id": "urn:uuid:39d90b25-5ddb-4518-8f05-1ac74f1c1f91",
                "success": false,
                "result": "Assertion urn:uuid:39d90b25-5ddb-4518-8f05-1ac74f1c1f91 has been revoked in RevocationList https://REDACTED/revocationlist/org14.json with reason: Generado por error 2",
                "name": "VERIFY_SIGNED_ASSERTION_NOT_REVOKED"
            }
        ],
        "valid": false
    }

@ottonomy ottonomy linked a pull request Feb 8, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant