-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL ID for image
typo?
#545
Comments
I agree with @BigBlueHat that the general convention is UpperCamelCase for class/entity types and lowerCamelCase for property names, as this is. |
@BigBlueHat which version of the context are you looking at? Current version (https://purl.imsglobal.org/spec/ob/v3p0/context-3.0.2.json) defines "image": {
"@id": "https://purl.imsglobal.org/spec/vc/ob/vocab.html#Image",
"@type": "@id"
} |
@xaviaracil yes that was the version of the context he was looking at. The issue is that the IRI for the type |
@ottonomy got it. I've created a new branch. My main doubt is in the "image": {
"@id": "https://purl.imsglobal.org/spec/vc/ob/vocab.html#image",
"@type": "@id"
}
I've set it to |
Does the top level property in the context enable a top level I see this snippet from the above link:
That seems incorrect. And:
Seems like some bug crept in. |
@ottonomy I don't see any Regarding the rare identifiers, they're pointing out to the description of the attribute for the given entity. That's why we have several definitions for |
I don't like the modeling of issuer.image to be a separate vocabulary concept from Achievement.image etc. Ideally we just use
This is one of those cases where some VC sub-communities have used some top-level metadata in the VC for display in various communities. I am perfectly fine myself with removing image from top-level display. It would be useful to approach wallet implementers who participated in the JFF Plugfests to see how they have implemented image display to see if they are targeting |
I agree with Nate re: using https://schema.org/image. The advantage is that it increases interoperability with other linked data models outside of 1EdTech's. For the plugfests, we listed badge image in the requirements but we should have required achievement.image which is what was intended. I don't think we need an image at the top level. There is enough flexibility to tailor the acheivement.image to the individual credential if implementers choose to do so. By keeping it to just achievement.image vs adding a top level image, wallets and other displayer don't need to make a decision about which one to display. This has already become an issue with name and achievement.name. |
Great, thanks for weighing in on not needing a top level image @kayaelle. 👍 to removing that from a future version of the context and reviewing other top level properties that are elsewhere duplicated in the model for the same reason (separate issue). |
The current context file contains (note the capital
I
in#Image
):However, that points to the object type definition (https://purl.imsglobal.org/spec/vc/ob/vocab.html#Image) and not the property definition (https://purl.imsglobal.org/spec/vc/ob/vocab.html#image).
Small but important difference.
Thanks!
🎩
The text was updated successfully, but these errors were encountered: