-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Earner Name to AchievementSubject #537
Comments
The @context does allow for "name" to be used throughout the credential. It is a high level property, not specific to AchievementSubject. The schema does not allow for name to be used in AchievementSubject. So it seems that either the schema should be adjusted or we should discuss how to include full names in the AchievementSubject. At DCC, we have examples of name being included in credentials because it aids in subject verification. |
Why |
It is extensible through inheritence. The https://github.com/1EdTech/openbadges-specification/blob/develop/ob_v3p0/common_credentials.lines#L42 For some reason, it is not showing as extensible in the spec HTML. Perhaps there is a bug in the renderer. I did not check the generated JSON Schema, but would not be surprised if it does not allow additional properties since both the JSON Schema and the Spec HTML use the MPS to interpret the model. Perhaps MPS logic was changed at some point to not propagate Mixins to derived types. |
I chatted with @ottonomy and he suggested that if I had type "Profile" to the CredentialSubject then name could be added but I'm still getting schema errors. Could you provide an example of how this could be extended and how the schema could/would allow it? Thanks! |
@amiller-ims I've checked MPS logic and it doesn't propagate |
@kayaelle Please update the schema, it should now allow additional properties. |
@xaviaracil Thanks! I'm going to put a partial example here to see if this is how other's would like to add a earner/subject name to an achievementSubject:
|
Thanks for stepping in and solving the issue with the schema @xaviaracil ! @kayaelle when we were talking about this, I mentioned the possibility of adding the
Because the
But sounds like indeed the issue was a mistaken I went through the schema and audited all other classes where additionalProperties is false. I'm not sure it is ever necessary to lock down the schema in this way, but certain places will be more restrictive of use cases than others. We've gone through several cases now one by one as we find what use cases had been blocked by the restrictions.
And from the CLR schema, which did not seem to have the same problems.
@xaviaracil let me know if you want me to open any additional issues to track these. |
Thanks @ottonomy - apologies for delay. Will review your comment above and reply soon. |
Here's a question - if we can now use "name" in credentialSubject and name is an attribute of profile but also a high level attribute that is used elsewhere, do we need to add Profile to type? givenName, familyName, are specific to profile but name is not and for many (especially international implementations) a single filed for an earner's name is appropriate. I don't have an opinion either way but I think it will be helpful for the group to make a recommendation and document it because many AchievementTypes will want to include the earner name including degrees, licenses, etc. Thanks! |
Additional Question - should the earner name be one of the identities in the IdentityObject instead of using Profile? seems like name could be added to this class And that would make it clear OR Profile could be added to this? OR... is userName close enough? |
I am leaning towards yeah, adding a new type to |
You do not need to add
As to what's "best", it's kind of up to how verifiers want to work to interpret various options. I think it would be more likely that such verifiers would have implemented some kind of handling for Without specific coordination between issuers, wallets, and verifiers, I would expect that data from Profile like |
Whoops, my commit message on the wrong branch accidentally closed this issue. Resolving. |
I'm leaning with @justinpitcher. Adding personName to the Identity Object is inline with the other identifiers. |
Hey @ottonomy - this is a step in the right direction but I will argue on behalf of the DCC and our members that are issuing degrees using Open Badges that name should be an explicit in the list of identifiers: https://1edtech.github.io/openbadges-specification/ob_v3p0.html#org.1edtech.ob.v3p0.identifiertypeenum.class Name will be used for subject verification where an earner's id could be presented at the time of presentation. If userName is on this list and email address, I don't see why name can't be added too so that the ecosystem has a consistent and interoperable way to identify their subjects by name. Request that we reopen this one and discuss at the next WG. Thanks! |
Reopened for further discussion about adding a new IdentifierType for Name. Changes to the schema for allowing extensibility made |
New IdentifierType added on September 22th. |
Could someone provide an example of how they would include an earner name in the AchievementSubject? There's an identifier referencing the identity object but name isn't one of the explicit options.
Also is Profile intended to be used only with the issuer?
We have a credential where we want to include a person's name -- ideally in one name field (vs given & family name)
Thanks for your help!
The text was updated successfully, but these errors were encountered: