Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LTI_Message_Launch get_public_key method issue due to JWK changes #72

Open
ThomasDumazet opened this issue Jun 17, 2022 · 1 comment
Open

Comments

@ThomasDumazet
Copy link

ThomasDumazet commented Jun 17, 2022

The method get_public_key returns openssl_pkey_get_details(JWK::parseKey($key)), but we encountered an error saying openssl_pkey_get_details() expects parameter 1 to be resource, object given.
After investigation, we discovered that firebase has changed the return type for JWK methods in January 2022.
The lti-1-3-php-library library doesn't require firebase/php-jwt but fproject/php-jwt that doesn't show these changes.
The problems start when the project using the lti-1-3-php-library library requires the firebase/php-jwt library as both of firebase/php-jwt and fproject/php-jwt libraries use the same namespace.

@JanHolger
Copy link

Hi Thomas there has been 2 PR's fixing both this and other errors that arise when using it together with the official firebase/php-jwt aswell as other Laravel issues. Unfortunately IMS seems to have died during the pandemic or something and there hasn't been any response on this in over 2 years now. If only your own code depends on php-jwt you could try using the outdated library instead but the parameter types are a little different. There is also an unofficial fork that contains all these changes: composer require packbackbooks/lti-1p3-tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants