From 64faccb09b93d1a3c130ea3e0ff59ff945aad40e Mon Sep 17 00:00:00 2001 From: Lucy Tomas Date: Fri, 19 Jan 2024 12:14:06 +0100 Subject: [PATCH] fix: possible double slash in canonical --- wp/headless-wp/includes/classes/Integrations/YoastSEO.php | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/wp/headless-wp/includes/classes/Integrations/YoastSEO.php b/wp/headless-wp/includes/classes/Integrations/YoastSEO.php index c36a1ec3a..2cb95933c 100644 --- a/wp/headless-wp/includes/classes/Integrations/YoastSEO.php +++ b/wp/headless-wp/includes/classes/Integrations/YoastSEO.php @@ -263,8 +263,8 @@ public function override_search_title( $title ) { } /** - * Yoast doesn't typically have a canonical for search and returns URL as the homepage URL. Generally https://gus.test/?s=test - * But with headstartwp nextjs app tipically there is a route for search page. + * Yoast doesn't have a canonical for search and returns URL as the homepage URL. Generally https://gus.test/?s=test + * But with headstartwp nextjs app usually there is a route for search page. * Default is 'search'. * * @param string $canonical The canonical URL. @@ -272,8 +272,10 @@ public function override_search_title( $title ) { */ public function override_search_canonical( $canonical ) { if ( $this->get_yoast_search_query_vars() ) { - $canonical .= apply_filters( 'tenup_headless_wp_search_route', 'search' ); + $search_route = apply_filters( 'tenup_headless_wp_search_route', 'search' ); + $canonical = rtrim( $canonical, '/' ) . '/' . $search_route; } + return $canonical; } }