Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add categories to pull screen - 2 #1244

Open
wants to merge 6 commits into
base: feature/show-category-pull
Choose a base branch
from
Open

Add categories to pull screen - 2 #1244

wants to merge 6 commits into from

Conversation

kirtangajjar
Copy link
Member

Description of the Change

Add categories to the pull screen. This is part 2 of 2 of this issue. This PR filters posts by categories.

Closes #428

How to test the Change

  1. Open post pull screen
  2. You should be able to see post categories in the filter.
  3. Select a category and filter. The posts should be filtered by categories.
  4. Pull the posts and verify only posts from that category have been pulled.
  5. Verify it on both internal and external connections.
  6. Verify it in conjunction with post type filter as well.

Changelog Entry

Added - Category filter in pull screen

Credits

Props @kirtangajjar

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@kirtangajjar kirtangajjar requested a review from a team as a code owner July 9, 2024 22:54
@kirtangajjar kirtangajjar requested review from Sidsector9 and faisal-alvi and removed request for a team and Sidsector9 July 9, 2024 22:54
@jeffpaul jeffpaul added this to the 2.1.0 milestone Jul 9, 2024
@jeffpaul jeffpaul linked an issue Jul 9, 2024 that may be closed by this pull request
add Category to bulk pull screen #428
Open
faisal-alvi
faisal-alvi requested changes Jul 12, 2024
View reviewed changes
Copy link
Member

@faisal-alvi faisal-alvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kirtangajjar thanks for working on this. I tested and found the category filter does not work. Please check the GIF:

1244-01

When I select test03, 0 posts should return as results, but it still shows the post with the Uncategorised category.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faisal-alvi faisal-alvi faisal-alvi requested changes

Assignees

@kirtangajjar kirtangajjar

Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

add Category to bulk pull screen
4 participants
@kirtangajjar @faisal-alvi @jeffpaul @Sidsector9