Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump WP-Env version. #1236

Merged
merged 9 commits into from
Aug 23, 2024
Merged

Bump WP-Env version. #1236

merged 9 commits into from
Aug 23, 2024

Conversation

peterwilsoncc
Copy link
Collaborator

@peterwilsoncc peterwilsoncc commented Jun 19, 2024 •
edited
Loading

Description of the Change

Bump wp-env to 1.5.0

Closes #

How to test the Change

  1. Run npm i; npm run build
  2. If you've created an environment previously run npm run env:destroy
  3. Run npm env:start
  4. Confirm the test environment has been started by visiting http://localhost:8888/
  5. Confirm the dev environment has started by visiting http://localhost
  6. Login to each to ensure the Distributor plugin has been installled and activated
  7. On the dev enviroment test sharing content between multiple sites.

Changelog Entry

Changed - Update WP-Env to 10.5.0

Credits

Props @peterwilsoncc, @Sidsector9, @jeffpaul

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@github-actions github-actions bot added this to the 2.1.0 milestone Jun 19, 2024
@github-actions github-actions bot added the needs:refresh This requires a refreshed PR to resolve. label Aug 5, 2024
@peterwilsoncc
Merge branch 'develop' into do/bump-wp-env
8814901 
# Conflicts:
#	package-lock.json
#	package.json
@github-actions github-actions bot removed the needs:refresh This requires a refreshed PR to resolve. label Aug 7, 2024
@jeffpaul
Copy link
Member

@peterwilsoncc is this still WIP/draft?

@peterwilsoncc
Copy link
Collaborator Author

@jeffpaul I was hoping it would resolve the issue with E2E tests but I don't think there is any harm in updating it even though that isn't the case.

@peterwilsoncc peterwilsoncc marked this pull request as ready for review August 20, 2024 23:10
@peterwilsoncc peterwilsoncc requested a review from a team as a code owner August 20, 2024 23:10
@peterwilsoncc peterwilsoncc requested review from faisal-alvi and removed request for a team August 20, 2024 23:10
@github-actions github-actions bot added the needs:feedback This requires reporter feedback to better understand the request. label Aug 20, 2024
@github-actions GitHub Actions
Copy link

@peterwilsoncc thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this?

@github-actions github-actions bot added needs:code-review This requires code review. and removed needs:feedback This requires reporter feedback to better understand the request. labels Aug 20, 2024
faisal-alvi
faisal-alvi approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@faisal-alvi faisal-alvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ignoring E2E failures since they’re unrelated and also failing in the develop branch.

@jeffpaul jeffpaul merged commit c67e29a into develop Aug 23, 2024
14 of 21 checks passed
@jeffpaul jeffpaul deleted the do/bump-wp-env branch August 23, 2024 12:55
@dkotter dkotter modified the milestones: 2.1.0, 2.0.6 Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faisal-alvi faisal-alvi faisal-alvi approved these changes

Assignees

@peterwilsoncc peterwilsoncc

Labels
needs:code-review This requires code review.
Projects
Open Source Practice
Archived in project
Milestone
2.0.6
Development

Successfully merging this pull request may close these issues.
5 participants
@peterwilsoncc @jeffpaul @faisal-alvi @dkotter @Sidsector9