Follow react rules of hooks #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirtangajjar
requested review from
iamdharmesh and
peterwilsoncc
and removed request for
a team and
iamdharmesh
assets/js/gutenberg-plugin.js
Outdated
| ) { | ||
| return null; | ||
| } | ||
|
|
||
| // eslint-disable-next-line no-shadow, react-hooks/rules-of-hooks -- permission checks are needed. |
There was a problem hiding this comment.
Suggested change
| // eslint-disable-next-line no-shadow, react-hooks/rules-of-hooks -- permission checks are needed. | |
| // eslint-disable-next-line no-shadow |
assets/js/gutenberg-plugin.js
Outdated
| // eslint-disable-next-line no-shadow, react-hooks/rules-of-hooks -- permission checks are needed. | ||
| const postType = useSelect( ( select ) => | ||
| select( 'core/editor' ).getCurrentPostType() | ||
| ); | ||
|
|
||
| // eslint-disable-next-line no-shadow, react-hooks/rules-of-hooks -- permission checks are needed. | ||
| // eslint-disable-next-line no-shadow -- permission checks are needed. |
There was a problem hiding this comment.
Suggested change
| // eslint-disable-next-line no-shadow -- permission checks are needed. | |
| // eslint-disable-next-line no-shadow |
assets/js/gutenberg-plugin.js
Outdated
| '#wp-admin-bar-distributor' | ||
| ); | ||
|
|
||
| // eslint-disable-next-line no-shadow -- permission checks are needed. |
There was a problem hiding this comment.
Suggested change
| // eslint-disable-next-line no-shadow -- permission checks are needed. | |
| // eslint-disable-next-line no-shadow |
assets/js/gutenberg-plugin.js
Outdated
| select( 'core/editor' ).getCurrentPost() | ||
| ); | ||
|
|
||
| // Ensure the user has proper permissions |
There was a problem hiding this comment.
May as well fix the comment style while we're changing this code.
Suggested change
| // Ensure the user has proper permissions | |
| // Ensure the user has proper permissions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Follow react rules of hooks
Closes #1205
How to test the Change
Changelog Entry
Credits
Props @kirtangajjar
Checklist: