The ability to set the priority of sending messages has been implemented #277
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
=======================================
Coverage 31.56% 31.56%
=======================================
Files 8 8
Lines 5028 5028
Branches 542 542
=======================================
Hits 1587 1587
Misses 3366 3366
Partials 75 75 ☔ View full report in Codecov by Sentry. |
src/Node.hpp
Outdated
| @@ -83,24 +83,24 @@ class Node | |||
|
|
|||
|
|
|||
| template <typename T> | |||
| Publisher<T> create_publisher(CanardMicrosecond const tx_timeout_usec); | |||
| Publisher<T> create_publisher(CanardMicrosecond const tx_timeout_usec, CanardPriority const tx_priority = CanardPriorityNominal); | |||
There was a problem hiding this comment.
Hi @bakul14 ☕ 👋 thank you very much for your contribution 🚀 . I do not prefer using default argument values, I'd rather do function overloading with another function exposing an additional parameter tx_priority. Can you please amend your PR accordingly?
There was a problem hiding this comment.
Ping @bakul14 ☕ 👋 - just checking in if you are still around - if not I'll have to close this PR unmerged.
There was a problem hiding this comment.
Yes, I remember about this PR. I think I'll do it next week.
bakul14
force-pushed
the
dev/mbakulevskiy/CYP-276
branch
from
168dddb
to
d786624
Compare
The priority of sending messages is set by the constructor argument when allocating the appropriate publishers, clients, servers. Thus, content will be sent with a predefined priority, which cannot be changed at runtime.